Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix TokenStream::to_string implementation dropping quotation marks #17994

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 29, 2024

Fixes #17986
We might wanna consider backporting this to beta if that's simple enough to do

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2024
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit c47b206 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

⌛ Testing commit c47b206 with merge a555c74...

bors added a commit that referenced this pull request Aug 29, 2024
fix: Fix proc-macro server crashing when parsing a non-lexable string into a TokenStream

We might wanna consider backporting this to beta if that's simple enough to do
@bors
Copy link
Collaborator

bors commented Aug 29, 2024

💔 Test failed - checks-actions

@Veykril Veykril force-pushed the proc-macro-srv-from-str-panic branch from c47b206 to 3d5f430 Compare August 29, 2024 06:34
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit 3d5f430 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

⌛ Testing commit 3d5f430 with merge 3dac862...

bors added a commit that referenced this pull request Aug 29, 2024
fix: Fix proc-macro server crashing when parsing a non-lexable string into a TokenStream

We might wanna consider backporting this to beta if that's simple enough to do
@Veykril Veykril changed the title fix: Fix proc-macro server crashing when parsing a non-lexable string into a TokenStream fix: Fix TokenStream::to_string implementation dropping quotation marks Aug 29, 2024
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit c103fee has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 29, 2024
fix: Fix TokenStream::to_string implementation dropping quotation marks

Fixes #17986
We might wanna consider backporting this to beta if that's simple enough to do
@bors
Copy link
Collaborator

bors commented Aug 29, 2024

⌛ Testing commit c103fee with merge 82ea248...

@Veykril Veykril force-pushed the proc-macro-srv-from-str-panic branch from c103fee to 69bcb42 Compare August 29, 2024 06:45
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit 69bcb42 has been approved by Veykril

It is now in the queue for this repository.

@Veykril Veykril force-pushed the proc-macro-srv-from-str-panic branch from 69bcb42 to abed6e2 Compare August 29, 2024 06:45
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit abed6e2 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

⌛ Testing commit abed6e2 with merge 40a1a4e...

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 40a1a4e to master...

@bors bors merged commit 40a1a4e into rust-lang:master Aug 29, 2024
11 checks passed
@lnicola
Copy link
Member

lnicola commented Aug 29, 2024

This doesn't seem to backport cleanly because the current beta is missing 93024ad.

@Veykril Veykril deleted the proc-macro-srv-from-str-panic branch August 29, 2024 10:26
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

Ah, then that should be fine, I think the regression came from that PR (or judging from the beta source, the issue doesnt seem to be present there) we missed the new beta cut off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible regression of the language server resulting in a panic
4 participants